Correctly compare dates for PR retrieval; fix tests #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
- Coverage 39.08% 38.88% -0.20%
==========================================
Files 8 8
Lines 394 396 +2
==========================================
Hits 154 154
- Misses 240 242 +2
Continue to review full report at Codecov.
|
|
@alexcanessa , would you be able to take a quick look at this PR? This issue affects node-saml and passport-saml, and I'd love to get this fix landed and released. If there is anything I can do to help the process along, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for comparing dates tries to compare a string to a
Dateobject. This causes additional pages of PRs to never be retrieved. This has been fixed.Also, constructing a date used the local-specific date instead of UTC, which means that the tests would only pass if one ran them from a UTC timezone. The code was corrected to build the dates using UTC.
I found this problem when working on node-saml/passport-saml#597